This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags


On Wed, 8 Jul 2015, Andreas Schwab wrote:

> Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com> writes:
> 
> > Right, I misread what that target was doing.  In any case, the right
> > fix here would be to make the check-local-headers target depend on *.d
> > (one of them I guess?) in a way that they're always generated before
> > the script is run.
> 
> It would need to depend on a target that recurses through all subdirs.
> The %.d:%.dt rule is triggered by include $(+depfiles).

I'd say that check-local-headers, instead of being a top-level test at 
all, should be a test present automatically in each subdirectory that 
checks only files in that subdirectory (and so doesn't need to depend on 
anything that recurses, only on something within that directory).  See 
what I said in 
<https://sourceware.org/ml/libc-alpha/2014-01/msg00197.html> about 
eliminating top-level tests.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]