This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Feng Gao <gfree dot wind at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 8 Jul 2015 15:14:36 +0530
- Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- Authentication-results: sourceware.org; auth=none
- References: <CA+6hz4qE5L-6LQEvVawdKtXXrqpP-c-VO1SmGtamRJUoRWYLRQ at mail dot gmail dot com> <20150707073145 dot GK13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4r4FjfTN5+AfM=x7_2xCC-3_FMeniMHdYNufBRrd4g8Lg at mail dot gmail dot com> <20150707162858 dot GR13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4omaZ2wjwCS1cKOXs27=p0oijUjtP9-8PVbyuDimQDtow at mail dot gmail dot com> <559CE58A dot 90706 at redhat dot com>
On 8 July 2015 at 14:25, Carlos O'Donell <carlos@redhat.com> wrote:
> This is a super annoying failure mode that happens when `make` fails or
> is not run. The fix is as follows, and I'll check it in shortly.
>
> 2015-07-08 Carlos O'Donell <carlos@redhat.com>
>
> * Makefile ($(objpfx)check-local-headers.out):
> Redirect input from /dev/null.
>
> diff --git a/Makefile b/Makefile
> index 658ccfa..c88b2e5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -262,7 +262,7 @@ endif
>
> $(objpfx)check-local-headers.out: scripts/check-local-headers.sh
> AWK='$(AWK)' scripts/check-local-headers.sh \
> - "$(includedir)" "$(objpfx)" > $@; \
> + "$(includedir)" "$(objpfx)" < /dev/null > $@; \
> $(evaluate-test)
That looks like a hack. Does it hang because $(objpfx) and
$(includedir) are not set? A better fix ought to be to ensure that
either 'make check' invokes make (and hence sets things up for the
check target) or it fails early and cleanly, i.e. irrespective of
whether the check-local-headers test is run or not.
Siddhesh
--
http://siddhesh.in