This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags

On 8 July 2015 at 14:25, Carlos O'Donell <> wrote:
> This is a super annoying failure mode that happens when `make` fails or
> is not run. The fix is as follows, and I'll check it in shortly.
> 2015-07-08  Carlos O'Donell  <>
>         * Makefile ($(objpfx)check-local-headers.out):
>         Redirect input from /dev/null.
> diff --git a/Makefile b/Makefile
> index 658ccfa..c88b2e5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -262,7 +262,7 @@ endif
>  $(objpfx)check-local-headers.out: scripts/
>         AWK='$(AWK)' scripts/ \
> -         "$(includedir)" "$(objpfx)" > $@; \
> +         "$(includedir)" "$(objpfx)" < /dev/null > $@; \
>         $(evaluate-test)

That looks like a hack.  Does it hang because $(objpfx) and
$(includedir) are not set?  A better fix ought to be to ensure that
either 'make check' invokes make (and hence sets things up for the
check target) or it fails early and cleanly, i.e. irrespective of
whether the check-local-headers test is run or not.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]