This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Feng Gao <gfree dot wind at gmail dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 08 Jul 2015 04:55:38 -0400
- Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- Authentication-results: sourceware.org; auth=none
- References: <CA+6hz4qE5L-6LQEvVawdKtXXrqpP-c-VO1SmGtamRJUoRWYLRQ at mail dot gmail dot com> <20150707073145 dot GK13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4r4FjfTN5+AfM=x7_2xCC-3_FMeniMHdYNufBRrd4g8Lg at mail dot gmail dot com> <20150707162858 dot GR13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4omaZ2wjwCS1cKOXs27=p0oijUjtP9-8PVbyuDimQDtow at mail dot gmail dot com>
On 07/08/2015 02:15 AM, Feng Gao wrote:
> It stop the following step for about 2 hours, so I have to cancel it.
>
> scripts/evaluate-test.sh c++-types-check $? false false >
> /home/fgao/works/my_git_codes/glibc-build/c++-types-check.test-result
> AWK='gawk' scripts/check-local-headers.sh \
> "/usr/include" "/home/fgao/works/my_git_codes/glibc-build/"
>> /home/fgao/works/my_git_codes/glibc-build/check-local-headers.out; \
> scripts/evaluate-test.sh check-local-headers $? false false >
> /home/fgao/works/my_git_codes/glibc-build/check-local-headers.test-result
This is a super annoying failure mode that happens when `make` fails or
is not run. The fix is as follows, and I'll check it in shortly.
2015-07-08 Carlos O'Donell <carlos@redhat.com>
* Makefile ($(objpfx)check-local-headers.out):
Redirect input from /dev/null.
diff --git a/Makefile b/Makefile
index 658ccfa..c88b2e5 100644
--- a/Makefile
+++ b/Makefile
@@ -262,7 +262,7 @@ endif
$(objpfx)check-local-headers.out: scripts/check-local-headers.sh
AWK='$(AWK)' scripts/check-local-headers.sh \
- "$(includedir)" "$(objpfx)" > $@; \
+ "$(includedir)" "$(objpfx)" < /dev/null > $@; \
$(evaluate-test)
ifneq ($(PERL),no)
--
c.