This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- From: Andreas Schwab <schwab at suse dot de>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>, Feng Gao <gfree dot wind at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 08 Jul 2015 17:11:52 +0200
- Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- Authentication-results: sourceware.org; auth=none
- References: <CA+6hz4qE5L-6LQEvVawdKtXXrqpP-c-VO1SmGtamRJUoRWYLRQ at mail dot gmail dot com> <20150707073145 dot GK13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4r4FjfTN5+AfM=x7_2xCC-3_FMeniMHdYNufBRrd4g8Lg at mail dot gmail dot com> <20150707162858 dot GR13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4omaZ2wjwCS1cKOXs27=p0oijUjtP9-8PVbyuDimQDtow at mail dot gmail dot com> <559CE58A dot 90706 at redhat dot com> <CAAHN_R3ZP7CsEEx-2AzDVO3Qh4eHsk+CwBE0E8=w5WRWqU2-zg at mail dot gmail dot com> <559D1BC3 dot 1060703 at redhat dot com> <CAAHN_R24tHX2Cu_vDZ+LtMmjAzjUdFAn0cDV8k2SsbfJksOLuA at mail dot gmail dot com> <559D3347 dot 8090903 at redhat dot com>
"Carlos O'Donell" <carlos@redhat.com> writes:
> The fix to read from /dev/null seems like the lowest cost immediate
> solution that yields a `make check` failure rather than a hang (which
> is terrible for automated test systems also).
Alternatively, add /dev/null to the awk command line. That would also
make the comment true:
# OK if *.os is missing.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."