This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Importing inttypes methods
On Tue, Aug 1, 2017 at 4:30 AM, Aditya Upadhyay <aadit0402@gmail.com> wrote:
> On Mon, Jul 31, 2017 at 3:38 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jul 30 11:41, Gedare Bloom wrote:
>>> All,
>>>
>>> It looks like to me like the str*_l functions in stdlib.h currently
>>> are actually being guarded by __GNU_VISIBLE rather than __BSD_VISIBLE.
>>> You should see if these locale functions from BSD are in glibc, if so
>>> then I believe GNU_VISIBLE is the more appropriate guard? Someone more
>>> knowledgeable on the feature test macros might comment.
>>
>> Yes, the functions are guarded with __GNU_VISIBLE, just as in glibc.
>> No, the {str,wcs}to{i,u}max_l functions are not defined in glibc at all,
>> so they should be __BSD_VISIBLE.
>>
> Do i need to modify the code of *max methods according to strtol
> method or is this ok for master ?
Aditya,
I don't quite understand your question. To rephrase Corinna's answer:
You should keep using the __BSD_VISIBLE as you have done, since the
new functions you port are not in glibc. You still need to rewrite
your code to take into consideration my other comments.
Gedare