Re: Importing inttypes methods

[Corinna Vinschen <vinschen at redhat dot com>]

On Jul 27 19:30, Aditya Upadhyay wrote:
> Hi,
> 
> I apologize for the inconvenience caused. Actually i am new to git and
> still learning commands. I am trying my best and want to assure you
> that i will be familiar with the git soon. I will try not to repeat
> the same mistakes again in future.
> I am attaching the fresh new patches for last 4 methods with all
> possible changes. I am requesting you to please review the patches.

Patches are fine and what we talked about, but I realized belatedly
that we have a problem with the inttypes.h header file:

Your patch includes xlocale.h only if __POSIX_VISIBLE >= 200809.
However, you declare the _l functions unconditionally.  This will
break builds which don't define _POSIX_SOURCE to the right value.

Additionally, these functions are BSD-only at the moment.  They are
neither in glibc nor in POSIX.

So, what we should do here is this:

* Include xlocale.h only if __BSD_VISIBLE.
* Declare the _l functions only if __BSD_VISIBLE, too.

It's your choice now:  Do you want to recreate the below patches
accordingly, or shall I aplly the patches as they are, and you create
a followup patch just fixing inttypes.h?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature