This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: glibc 2.28 - Please commit ISO C threads support.



On 24/07/2018 17:44, Florian Weimer wrote:
> On 07/24/2018 10:38 PM, H.J. Lu wrote:
>>> I don't get this test failure on Fedora 28 x86-64.
>>>
>> It failed at random:
>>
>> [hjl@gnu-cfl-1 build-x86_64-linux]$ ./nptl/tst-cnd-timedwait
>> error: tst-cnd-timedwait.c:59: cnd_timedwait failed
>> error: 1 test failures
>> [hjl@gnu-cfl-1 build-x86_64-linux]$ ./nptl/tst-cnd-timedwait
>> error: tst-cnd-timedwait.c:59: cnd_timedwait failed
>> error: 1 test failures
>> [hjl@gnu-cfl-1 build-x86_64-linux]$ ./nptl/tst-cnd-timedwait
>> [hjl@gnu-cfl-1 build-x86_64-linux]$ ./nptl/tst-cnd-timedwait
>> error: tst-cnd-timedwait.c:59: cnd_timedwait failed
>> error: 1 test failures
>> [hjl@gnu-cfl-1 build-x86_64-linux]$ ./nptl/tst-cnd-timedwait
>> error: tst-cnd-timedwait.c:59: cnd_timedwait failed
>> error: 1 test failures
>> [hjl@gnu-cfl-1 build-x86_64-linux]$
> 
> Oh, yes.  It will fail if the timespec because invalid due to nanosecond overflow.  I believe there is another bug in the test.  Will send a patch.

Indeed, maybe just increment one second and add a sleep like
tst-cond15.c.  I think it is worth to add a timeout check
as well.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]