This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Cleanup ppc code dealing with opcode dumps
On Sun, May 06, 2018 at 08:39:11AM -0400, Hans-Peter Nilsson wrote:
> On Sun, 6 May 2018, Alan Modra wrote:
> > On Fri, May 04, 2018 at 04:37:34PM -0500, Peter Bergner wrote:
> > > gas/
> > > * config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
> > > to dump the entire opcode table.
> > > (ppc_setup_opcodes) <spe2_opcodes>: Likewise.
> > > (ppc_setup_opcodes) <vle_opcodes>: Likewise. Fix calculation of
> > > opcode index.
> >
> > OK with some ChangeLog fixes. Normally you'd write the angle brackets
> > inside the parentheses, for example:
> >
> > * ppc-dis.c (disassemble_init_powerpc <powerpc_opcd_indices>): Rewrite
> > initialization loop.
>
> Ackchyually, no, it was correct as written.
> <https://www.gnu.org/prep/standards/html_node/Indicating-the-Part-Changed.html>
Huh, then I've been writing ChangeLogs wrongly for years.. Oh well,
better leave it as you had it Peter, and I'll try to remember the
correct way.
--
Alan Modra
Australia Development Lab, IBM