This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cleanup ppc code dealing with opcode dumps

On 5/6/18 1:35 AM, Alan Modra wrote:
> On Fri, May 04, 2018 at 04:37:34PM -0500, Peter Bergner wrote:
>> include/
>> 	* opcode/ppc.h (powerpc_num_opcodes): Change type to unsigned.
>> 	(vle_num_opcodes): Likewise.
>> 	(spe2_num_opcodes): Likewise.
>>
>> opcodes/
>> 	* ppc-opc.c (powerpc_num_opcodes): Likewise.
>> 	(vle_num_opcodes): Likewise.
>> 	(spe2_num_opcodes): Likewise.
>> 	* ppc-dis.c (disassemble_init_powerpc) <powerpc_opcd_indices>: Rewrite
>> 	initialization loop.
>> 	(disassemble_init_powerpc) <vle_opcd_indices>: Likewise.
>> 	(disassemble_init_powerpc) <spe2_opcd_indices>: Likewise.  Initialize
>> 	only once.
>>
>> gas/
>> 	* config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
>> 	to dump the entire opcode table.
>> 	(ppc_setup_opcodes) <spe2_opcodes>: Likewise.
>> 	(ppc_setup_opcodes) <vle_opcodes>: Likewise.  Fix calculation of
>> 	opcode index.
> 
> OK with some ChangeLog fixes.  Normally you'd write the angle brackets
> inside the parentheses, for example:

Ok, I committed the changes with the original ChangeLog entries per
Hans-Peter's comment.  Thanks.

Peter
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]