This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Cleanup ppc code dealing with opcode dumps
- From: Alan Modra <amodra at gmail dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Sun, 6 May 2018 16:05:26 +0930
- Subject: Re: [PATCH] Cleanup ppc code dealing with opcode dumps
- References: <132c9e91-2c45-e632-0c5b-4bea0863cd4c@vnet.ibm.com>
On Fri, May 04, 2018 at 04:37:34PM -0500, Peter Bergner wrote:
> include/
> * opcode/ppc.h (powerpc_num_opcodes): Change type to unsigned.
> (vle_num_opcodes): Likewise.
> (spe2_num_opcodes): Likewise.
>
> opcodes/
> * ppc-opc.c (powerpc_num_opcodes): Likewise.
> (vle_num_opcodes): Likewise.
> (spe2_num_opcodes): Likewise.
> * ppc-dis.c (disassemble_init_powerpc) <powerpc_opcd_indices>: Rewrite
> initialization loop.
> (disassemble_init_powerpc) <vle_opcd_indices>: Likewise.
> (disassemble_init_powerpc) <spe2_opcd_indices>: Likewise. Initialize
> only once.
>
> gas/
> * config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
> to dump the entire opcode table.
> (ppc_setup_opcodes) <spe2_opcodes>: Likewise.
> (ppc_setup_opcodes) <vle_opcodes>: Likewise. Fix calculation of
> opcode index.
OK with some ChangeLog fixes. Normally you'd write the angle brackets
inside the parentheses, for example:
* ppc-dis.c (disassemble_init_powerpc <powerpc_opcd_indices>): Rewrite
initialization loop.
--
Alan Modra
Australia Development Lab, IBM