This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: Add .nop directive to assembler

Hi,

On Thu, 15 Feb 2018, H.J. Lu wrote:

> OK for master?

@@ -4523,6 +4523,7 @@ Some machine configurations provide additional directives.
 * Sleb128::                    @code{.sleb128 @var{expressions}}
 @ifclear no-space-dir
 * Space::                       @code{.space @var{size} , @var{fill}}
+* Nop::                         @code{.nop @var{size}[, @var{limit}]}
 @end ifclear
 @ifset have-stabs
 * Stab::                        @code{.stabd, .stabn, .stabs}

You probably don't want to have the Nop entry conditional on no-space-dir. 
The index is also supposed to be sorted alphabetical.  And the description 
of above item still says "limit" instead of "control".

@@ -450,14 +453,18 @@ cvt_frag_to_fill (segT sec ATTRIBUTE_UNUSED, fragS *fragP)
       if (fragP->fr_offset < 0)
        {
          as_bad_where (fragP->fr_file, fragP->fr_line,
-                       _("attempt to .org/.space backwards? (%ld)"),
+                       _("attempt to .org/.space/,nop backwards? (%ld)"),

".nop", not ",nop".


Ciao,
Michael.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]