This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: Add .nop directive to assembler


On Wed, Feb 14, 2018 at 7:55 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Wed, 14 Feb 2018, H.J. Lu wrote:
>
>> > Did you consider generalizing .skip instead (e.g. by allowing its FILL
>> > to be "@NOP" alongside an absolute expression)? I have to admit that
>> > adding a new directive looks a little odd to me when all you want is
>> > some more flexibility with an existing one.
>>
>> This requires much bigger changes.  Also I like ".not SIZE, LIMIT". But
>> if everyone agrees that we should extend .skip, we can do that. This may
>> also remove the size limit.
>
> If I may chime in, it didn't occur to me before Jan mentioned it, but yes,
> I also think extending .fill feels more natural.
>

No, .fill isn't what we want.  We need to extend

.skip SIZE , FILL

So what should FILL look like?

BTW, to implement that, we need to extend both rs_fill and rs_space relax
states.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]