This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] More Thumb2 condexec bugs


> The tc-arm.c changes are fine.  However, I'm not particularly keen on
>
> the dump file for the test.  For example:
> > Index: testsuite/gas/arm/thumb2_it.d
> > +0+040 <[^>]+> 0048             lsl.*   r0, r1, #1
>
> This patttern would match any amount of random text after the mnemonic
> (I think it should really be)
>
> +0+040 <[^>]+> 0048             lsl(eq|s)   r0, r1, #1
>
> And ultimately (once the disassembler is fixed) the 's' alternative
> should be removed (since this particular insn is conditionally
> executed).

Applied with those changes.

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]