[Bug runtime/30415] conflicting types for ‘kallsyms_on_each_symbol’

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30415

--- Comment #14 from William Cohen <wcohen at redhat dot com> ---
Hi Martin,
The patch is looking pretty good.  There are just a few minor comments I have
on it.

One concern have is if RHEL backport some of the live patching support
to RHEL kernel the kernel version checks might not catch that.
However, probably better to just use the kernel version as currently
done and fix the problem with autoconf check if/when RHEL backports
patches.


Is there a need for both stapkp_kernel_symbol_callback and
stapkp_module_symbol_callback?  in kprobes.c?  They look the same with
the exception of the function name.  It would simplfy the code if
those were combined into a single function.


In runtime/linux/kprobe.c have:

extern void *_stp_module_kallsyms_on_each_symbol;

However, its static in runtime/linux/runtime.h:

static void *_stp_module_kallsyms_on_each_symbol;

-- 
You are receiving this mail because:
You are the assignee for the bug.