[Bug runtime/30415] conflicting types for ‘kallsyms_on_each_symbol’

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30415

--- Comment #15 from Martin Cermak <mcermak at redhat dot com> ---
Created attachment 14913
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14913&action=edit
possible patch

(In reply to William Cohen from comment #14)
> Is there a need for both stapkp_kernel_symbol_callback and
> stapkp_module_symbol_callback?  in kprobes.c?  They look the same with
> the exception of the function name.  It would simplfy the code if
> those were combined into a single function.

Absolutely, I've combined them into one single stapkp_symbol_callback()

> In runtime/linux/kprobe.c have:
> 
> extern void *_stp_module_kallsyms_on_each_symbol;
> 
> However, its static in runtime/linux/runtime.h:
> 
> static void *_stp_module_kallsyms_on_each_symbol;

I've dropped the 'static' access control constraint in the header.

-- 
You are receiving this mail because:
You are the assignee for the bug.