[Bug runtime/30415] conflicting types for ‘kallsyms_on_each_symbol’

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30415

--- Comment #13 from Martin Cermak <mcermak at redhat dot com> ---
Created attachment 14912
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14912&action=edit
possible patch

Thanks a ton for looking into this, Will.

I've forgotten to take into account Comment#9, which says that starting from
kernel commit 013c1667cf78 on, the module_kallsyms_on_each_symbol() isn't
called from kallsyms_on_each_symbol(). So, looking at the kernel git tags:

$ git log -1000000  --oneline --decorate |& fgrep -e '(tag:' -e 013c1667cf |
fgrep -C3 013c1667cf
a38fd8748464 (tag: v5.12-rc2) Linux 5.12-rc2
fe07bfda2fb9 (tag: v5.12-rc1-dontuse) Linux 5.12-rc1
f40ddce88593 (tag: v5.11) Linux 5.11
013c1667cf78 kallsyms: refactor {,module_}kallsyms_on_each_symbol
92bf22614b21 (tag: v5.11-rc7) Linux 5.11-rc7
1048ba83fb1c (tag: v5.11-rc6) Linux 5.11-rc6
6ee1d745b7c9 (tag: v5.11-rc5) Linux 5.11-rc5
$

This seems to mean that some of the 5.11 kernel versions did have this commit
and some didn't. So I think it is safe to expect that kernel versions 5.12 and
higher have that commit. I've added KERNEL_VERSION() gates to reflect this, and
it seems to solve the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.