M_LOG2_E vs. M_LN2 cleanup patch

Jeff Johnston jjohnstn@redhat.com
Fri Dec 3 21:45:00 GMT 2010


My bad.  Must have typed libm on the commit.  Thanks for following up.

-- Jeff J.

On 12/03/2010 08:49 AM, Howland Craig D (Craig) wrote:
> Jeff:
>       The math.h part of the patch appears to have not worked, as math.h
> is unchanged in CVS.  Here's that part of the patch, re-generated fresh.
> 				Craig
>
>
> -----Original Message-----
> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]
> On Behalf Of Jeff Johnston
> Sent: Thursday, December 02, 2010 2:58 PM
> To: newlib@sourceware.org
> Subject: Re: M_LOG2_E vs. M_LN2 cleanup patch
>
> Patch checked in.
>
> -- Jeff J.
>
> On 12/02/2010 02:50 PM, Howland Craig D (Craig) wrote:
>> Jeff:
>>        Ping.  (It's old, but the patch ought to still work.  I could
>> refresh it if there is any trouble.)
>> 				Craig
>>
>> -----Original Message-----
>> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]
>> On Behalf Of Howland Craig D (Craig)
>> Sent: Tuesday, February 23, 2010 8:32 PM
>> To: Newlib
>> Subject: M_LOG2_E vs. M_LN2 cleanup patch
>>
>> Attached is a patch that changes the source from using M_LOG2_E--a
>> non-standard name for log2(e)--to using M_LN2--a POSIX name for the
>> same value.
>>
>> The code actually uses both M_LOG2_E and _M_LOG2_E.  I kept the same
>> basic form of initial underscore when editing.  (That is, I'm not
>> cleaning up the inconsistency of the lead _, but only the base name.
>> The use of lead _ does not matter at the moment, but might be
>> affected by my pending question about the use of _XOPEN_SOURCE, so
>> I'm leaving that for later.)
>>
>> Both M_LOG2_E and M_LN2 defines are kept in math.h--only the use
>> by other files is changed.
>>
>> Craig
>



More information about the Newlib mailing list