[PATCH v4 3/3] aarch64: Add tests for glibc.cpu.aarch64_bti behaviour

[Yury Khrustalev]

On Thu, Dec 04, 2025 at 09:41:05AM +0000, Yury Khrustalev wrote:
> On Wed, Dec 03, 2025 at 12:58:01PM -0300, Adhemerval Zanella Netto wrote:
> > 
> > On 01/12/25 13:14, Yury Khrustalev wrote:
> > > Check that the new tunable changes behaviour correctly:
> > > 
> > >  * When BTI is enforced, any unmarked binary that is loaded
> > >    results in an error: either an abort or dlopen error when
> > >    this binary is loaded via dlopen.
> > >  * When BTI is not enforced, it is OK to load an unmarked
> > >    binary.
> > 
> > Just a small nit below, there is no need to change a new version.  I think
> > there is no need to check for static dlopen.
> > 
> > LGTM, thanks.
> > 
> > Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
> Thanks for the review!
> 
> > > ---
> > > ...
> > >
> > > +
> > > +modules-names += \
> > > +  tst-bti-mod \
> > > +  tst-bti-mod-prot \
> > > +  tst-bti-mod-unprot
> > 
> > Add a '\' and a # modules-names as the end of the list, like the tests.
> 
> Good point! However it's a bit more involved than that. This small fix
> somehow upsets lint-makefiles and the patch that this test suggests
> makes not sense to me. I'll try to find how to work around this.
> 

This is because the modules-names variable is updated in more than one
place and another place unrelated to my change is not formatted
correctly. Is it OK of I add the following fix to my patch? Or should I
post it separately and then rebase my series on top?

  diff --git a/sysdeps/aarch64/Makefile b/sysdeps/aarch64/Makefile
  index c00fe9dc00..d0e4be8829 100644
  --- a/sysdeps/aarch64/Makefile
  +++ b/sysdeps/aarch64/Makefile
  @@ -3,16 +3,20 @@ long-double-fcts = yes
   ifeq ($(subdir),elf)
   sysdep-dl-routines += \
     dl-bti \
  -  dl-gcs
  +  dl-gcs \
  +  # sysdep-dl-routines
   
  -tests += tst-audit26 \
  -        tst-audit27
  +tests += \
  +  tst-audit26 \
  +  tst-audit27 \
  +  # tests
   
   modules-names += \
  -    tst-audit26mod \
  -    tst-auditmod26 \
  -    tst-audit27mod \
  -    tst-auditmod27
  +  tst-audit26mod \
  +  tst-audit27mod \
  +  tst-auditmod26 \
  +  tst-auditmod27 \
  +  # modules-names
   
   $(objpfx)tst-audit26: $(objpfx)tst-audit26mod.so \
                        $(objpfx)tst-auditmod26.so

Thanks,
Yury