[PATCH v4 3/3] aarch64: Add tests for glibc.cpu.aarch64_bti behaviour

Yury Khrustalev yury.khrustalev@arm.com
Thu Dec 4 09:41:05 GMT 2025


On Wed, Dec 03, 2025 at 12:58:01PM -0300, Adhemerval Zanella Netto wrote:
> 
> On 01/12/25 13:14, Yury Khrustalev wrote:
> > Check that the new tunable changes behaviour correctly:
> > 
> >  * When BTI is enforced, any unmarked binary that is loaded
> >    results in an error: either an abort or dlopen error when
> >    this binary is loaded via dlopen.
> >  * When BTI is not enforced, it is OK to load an unmarked
> >    binary.
> 
> Just a small nit below, there is no need to change a new version.  I think
> there is no need to check for static dlopen.
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Thanks for the review!

> > ---
> > ...
> >
> > +
> > +modules-names += \
> > +  tst-bti-mod \
> > +  tst-bti-mod-prot \
> > +  tst-bti-mod-unprot
> 
> Add a '\' and a # modules-names as the end of the list, like the tests.

Good point! However it's a bit more involved than that. This small fix
somehow upsets lint-makefiles and the patch that this test suggests
makes not sense to me. I'll try to find how to work around this.

Thanks,
Yury



More information about the Libc-alpha mailing list