[PATCH] Support HWCAPs for MIPS
Matthew Fortune
Matthew.Fortune@imgtec.com
Fri Mar 6 16:44:00 GMT 2015
Carlos O'Donell <carlos@redhat.com> writes:
> On 03/06/2015 10:52 AM, Andreas Schwab wrote:
> > Mike Frysinger <vapier@gentoo.org> writes:
> >
> >>> +{
> >>> + int i;
> >>> +
> >>> + /* Fallback to unknown output mechanism. */ if (type ==
> >>> + AT_HWCAP2)
> >>> + return -1;
> >>> +
> >>> + _dl_printf ("AT_HWCAP: ");
> >>> +
> >>> + for (i = 0; i < _DL_HWCAP_COUNT; ++i)
> >>> + if (word & (1 << i))
> >>
> >> i is an int, but word is an unsigned long int.
> >
> > That's not a problem. The problem is that 1 is an int.
>
> Right, you want 1U.
>
> Which reminds me that elf.h is all wrong also and needs 1U everywhere.
Thanks Mike for the review. I admit to blindly stealing this from
another port in glibc (I don't recall which). Since I still haven't
managed to get any HWCAPs into mainline kernel then I was just going
to wait until I had a HWCAP to include before pushing ahead with
this.
Should I update this and get the framework committed while waiting for
things to trickle in to the kernel?
Thanks,
Matthew
More information about the Libc-alpha
mailing list