[PATCH] Support HWCAPs for MIPS

Carlos O'Donell carlos@redhat.com
Fri Mar 6 15:57:00 GMT 2015


On 03/06/2015 10:52 AM, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> 
>>> +{
>>> +  int i;
>>> +
>>> +  /* Fallback to unknown output mechanism.  */
>>> +  if (type == AT_HWCAP2)
>>> +    return -1;
>>> +
>>> +  _dl_printf ("AT_HWCAP:   ");
>>> +
>>> +  for (i = 0; i < _DL_HWCAP_COUNT; ++i)
>>> +    if (word & (1 << i))
>>
>> i is an int, but word is an unsigned long int.
> 
> That's not a problem.  The problem is that 1 is an int.

Right, you want 1U.

Which reminds me that elf.h is all wrong also and needs 1U everywhere.

Cheers,
Carlos.



More information about the Libc-alpha mailing list