[PATCH] Support HWCAPs for MIPS

Andreas Schwab schwab@linux-m68k.org
Fri Mar 6 16:47:00 GMT 2015


"Carlos O'Donell" <carlos@redhat.com> writes:

> On 03/06/2015 10:52 AM, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>> 
>>>> +{
>>>> +  int i;
>>>> +
>>>> +  /* Fallback to unknown output mechanism.  */
>>>> +  if (type == AT_HWCAP2)
>>>> +    return -1;
>>>> +
>>>> +  _dl_printf ("AT_HWCAP:   ");
>>>> +
>>>> +  for (i = 0; i < _DL_HWCAP_COUNT; ++i)
>>>> +    if (word & (1 << i))
>>>
>>> i is an int, but word is an unsigned long int.
>> 
>> That's not a problem.  The problem is that 1 is an int.
>
> Right, you want 1U.

unsigned int is still a problem.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Libc-alpha mailing list