[patch] Fix BZ#16374 -- don't use mmap for FILE buffers

Florian Weimer fweimer@redhat.com
Mon Feb 16 18:32:00 GMT 2015


On 02/16/2015 07:06 PM, Paul Pluzhnikov wrote:
> Greetings,
> 
> I believe we've reached a consensus in
> https://sourceware.org/ml/libc-alpha/2015-02/msg00010.html -- using
> mmap to allocate FILE buffers is really not a good idea.
> 
> Attached patch replaces mmap()s with calloc()s.

Why is calloc needed?  The implementation needs to keep track of the
active buffer range anyway, and the old fallback code had just a malloc
AFAICS.

-- 
Florian Weimer / Red Hat Product Security



More information about the Libc-alpha mailing list