[patch] Fix BZ#16374 -- don't use mmap for FILE buffers

Paul Pluzhnikov ppluzhnikov@google.com
Mon Feb 16 20:54:00 GMT 2015


On Mon, Feb 16, 2015 at 12:10 PM, Florian Weimer <fweimer@redhat.com> wrote:

> I think it will still be a net win, but fopen/fclose pairs might now run
> into the issue discussed in the ‘Reduce worst-case behaviour with
> madvise and refault overhead’ thread. :-P

Thanks for pointing out that thread.

I don't believe we'll run into that here: AFAICT the mmap threshold is
DEFAULT_MMAP_THRESHOLD_MIN currently at 128KB, while the buffers we
are malloc()ing here are _IO_BUFSIZ of 8KB.


-- 
Paul Pluzhnikov



More information about the Libc-alpha mailing list