[PATCH] memset: fix define usage for shared libs
Mike Frysinger
vapier@gentoo.org
Thu Apr 5 17:28:00 GMT 2012
On Thursday 05 April 2012 13:08:19 Andreas Jaeger wrote:
> On 04/05/2012 06:12 PM, Mike Frysinger wrote:
> > On Thursday 05 April 2012 02:29:27 Carlos O'Donell wrote:
> >> On Wed, Apr 4, 2012 at 9:26 PM, Mike Frysinger<vapier@gentoo.org> wrote:
> >>> The proper define to check "am I in a shared lib" is "SHARED", not
> >>> "PIC". The two new memset_chk functions incorrectly depend on "PIC".
> >>>
> >>> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> >>>
> >>> 2011-02-22 Mike Frysinger<vapier@gentoo.org>
> >>>
> >>> * sysdeps/i386/i686/memset_chk.S: Change PIC to SHARED.
> >>> * sysdeps/x86_64/memset_chk.S: Likewise.
> >>
> >> Please check this in.
> >
> > i don't recall being granted access to glibc git repo ... i'm in the
> > sourceware.org cvs tree ...
>
> Mike, shall I apply this for you - or do you want to wait until you have
> write access?
i can use it as an exercise of merging things. this fix has been around for a
while, so it can wait a bit longer since there's time before 2.16. thanks
though.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20120405/4beec87f/attachment.sig>
More information about the Libc-alpha
mailing list