[PATCH] memset: fix define usage for shared libs

Andreas Jaeger aj@suse.com
Thu Apr 5 17:09:00 GMT 2012


On 04/05/2012 06:12 PM, Mike Frysinger wrote:
> On Thursday 05 April 2012 02:29:27 Carlos O'Donell wrote:
>> On Wed, Apr 4, 2012 at 9:26 PM, Mike Frysinger<vapier@gentoo.org>  wrote:
>>> The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
>>> The two new memset_chk functions incorrectly depend on "PIC".
>>>
>>> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
>>>
>>> 2011-02-22  Mike Frysinger<vapier@gentoo.org>
>>>
>>>         * sysdeps/i386/i686/memset_chk.S: Change PIC to SHARED.
>>>         * sysdeps/x86_64/memset_chk.S: Likewise.
>>
>> Please check this in.
>
> i don't recall being granted access to glibc git repo ... i'm in the
> sourceware.org cvs tree ...


Mike, shall I apply this for you - or do you want to wait until you have 
write access?

Andreas
-- 
  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



More information about the Libc-alpha mailing list