[PATCH][GAS][aarch64] GAS doesn't validate the architecture version for any tlbi registers

Nick Clifton nickc@redhat.com
Mon Aug 10 15:23:33 GMT 2020


Hi Przemyslaw,

> OK for master branch?

Approved and applied.

One small note:

> gas/ChangeLog:
> 2020-08-03  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> 
> 	* gas/config/tc-aarch64.c (parse_sys_reg): Call to 
> 	aarch64_sys_ins_reg_supported_p instead of aarch64_sys_reg_supported_p.
> 	(parse_sys_ins_reg): Add aarch64_sys_reg_deprecated_p check.
> 	* include/opcode/aarch64.h (aarch64_sys_reg_deprecated_p): Functions
> 	paramaters changed.
> 	(aarch64_sys_reg_supported_p): Function removed.
> 	(aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> 	* opcodes/aarch64-opc.c (aarch64_print_operand):
> 	(aarch64_sys_reg_deprecated_p): Functions paramaters changed.
> 	(aarch64_sys_reg_supported_p): Function removed.
> 	(aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> 	(aarch64_sys_ins_reg_supported_p): Merged aarch64_sys_reg_supported_p
> 	into this function.
> 	* gas/testsuite/gas/aarch64/illegal-sysreg-5.d: New test.
> 	* gas/testsuite/gas/aarch64/illegal-sysreg-5.l: New test.
> 	* gas/testsuite/gas/aarch64/sysreg-5.s: New test.

We prefer to have the changelog entries separated by major sub-directory,
so the above should really be three distinct changelogs, one for gas (and
its testsuite), one for opcodes and one for include.

I made this split when I checked in your patch.

Cheers
  Nick



More information about the Binutils mailing list