[PATCH][GAS][aarch64] GAS doesn't validate the architecture version for any tlbi registers

[Alex Coplan]

For some reason the list got dropped here. Adding binutils@ back in,
sorry for the noise.

> -----Original Message-----
> From: Alex Coplan
> Sent: 10 August 2020 17:05
> To: 'nickc@redhat.com'; Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com>
> Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>; Ramana Radhakrishnan
> <Ramana.Radhakrishnan@arm.com>
> Subject: RE: [PATCH][GAS][aarch64] GAS doesn't validate the architecture
> version for any tlbi registers
> 
> Hi Nick,
> 
> > -----Original Message-----
> > From: Binutils <binutils-bounces@sourceware.org> On Behalf Of Nick
> > Clifton via Binutils
> > Sent: 10 August 2020 16:24
> > To: Przemyslaw Wirkus <Przemyslaw.Wirkus@arm.com>;
> > binutils@sourceware.org
> > Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>; Ramana Radhakrishnan
> > <Ramana.Radhakrishnan@arm.com>
> > Subject: Re: [PATCH][GAS][aarch64] GAS doesn't validate the
> architecture
> > version for any tlbi registers
> >
> > Hi Przemyslaw,
> >
> > > OK for master branch?
> >
> > Approved and applied.
> >
> > One small note:
> >
> > > gas/ChangeLog:
> > > 2020-08-03  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> > >
> > > 	* gas/config/tc-aarch64.c (parse_sys_reg): Call to
> > > 	aarch64_sys_ins_reg_supported_p instead of
> > aarch64_sys_reg_supported_p.
> > > 	(parse_sys_ins_reg): Add aarch64_sys_reg_deprecated_p check.
> > > 	* include/opcode/aarch64.h (aarch64_sys_reg_deprecated_p):
> > Functions
> > > 	paramaters changed.
> > > 	(aarch64_sys_reg_supported_p): Function removed.
> > > 	(aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> > > 	* opcodes/aarch64-opc.c (aarch64_print_operand):
> > > 	(aarch64_sys_reg_deprecated_p): Functions paramaters changed.
> > > 	(aarch64_sys_reg_supported_p): Function removed.
> > > 	(aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> > > 	(aarch64_sys_ins_reg_supported_p): Merged
> > aarch64_sys_reg_supported_p
> > > 	into this function.
> > > 	* gas/testsuite/gas/aarch64/illegal-sysreg-5.d: New test.
> > > 	* gas/testsuite/gas/aarch64/illegal-sysreg-5.l: New test.
> > > 	* gas/testsuite/gas/aarch64/sysreg-5.s: New test.
> >
> > We prefer to have the changelog entries separated by major sub-
> directory,
> > so the above should really be three distinct changelogs, one for gas
> (and
> > its testsuite), one for opcodes and one for include.
> >
> > I made this split when I checked in your patch.
> 
> The change to gas/ChangeLog doesn't look quite right here:
> 
> --- a/gas/ChangeLog
> +++ b/gas/ChangeLog
> @@ -1,3 +1,23 @@
> +       * include/opcode/aarch64.h (aarch64_sys_reg_deprecated_p):
> Functions
> +       paramaters changed.
> +       (aarch64_sys_reg_supported_p): Function removed.
> +       (aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> +       * opcodes/aarch64-opc.c (aarch64_print_operand):
> +       (aarch64_sys_reg_deprecated_p): Functions paramaters changed.
> +       (aarch64_sys_reg_supported_p): Function removed.
> +       (aarch64_sys_ins_reg_supported_p): Functions paramaters changed.
> +       (aarch64_sys_ins_reg_supported_p): Merged
> aarch64_sys_reg_supported_p
> +       into this function.
> +2020-08-10  Przemyslaw Wirkus  <przemyslaw.wirkus@arm.com>
> +
> +       * config/tc-aarch64.c (parse_sys_reg): Call to
> +       aarch64_sys_ins_reg_supported_p instead of
> +       aarch64_sys_reg_supported_p.
> +       (parse_sys_ins_reg): Add aarch64_sys_reg_deprecated_p check.
> +       * testsuite/gas/aarch64/illegal-sysreg-5.d: New test.
> +       * testsuite/gas/aarch64/illegal-sysreg-5.l: New test.
> +       * testsuite/gas/aarch64/sysreg-5.s: New test.
> 
> Looks like everything above the header doesn't belong here?
> 
> Thanks,
> Alex