[PATCH 3/6] Add Visium support to bfd

Eric Botcazou ebotcazou@adacore.com
Fri Dec 5 10:21:00 GMT 2014


> Lose "set_" in the name, you're not setting anything here.

Renamed into visium_parity_bit.

> Also p ^= might save some future trouble, since bfd_vma can be 64-bit.

Right, I agree that the ^= idiom is clearly superior here.  Also changed in 
the assembler (visium_update_parity_bit).

> > +  sym_hashes_end =
> > +    sym_hashes + symtab_hdr->sh_size / sizeof (Elf32_External_Sym);
> > +  if (!elf_bad_symtab (abfd))
> > +    sym_hashes_end -= symtab_hdr->sh_info;
> 
> You won't ever have elf_bad_symtab set and in any case, sym_hashes_end
> looks to be unused.

Removed.

> > +   There is some attempt to make this function usable for many
> > architectures, +   both USE_REL and USE_RELA ['twould be nice if such a
> > critter existed], +   if only to serve as a learning tool.
> 
> Really?

No. :-)  Head comment ditched (and ATTRIBUTE_UNUSED removed from output_bfd).

Thanks for the review.

-- 
Eric Botcazou



More information about the Binutils mailing list