[PATCH 3/6] Add Visium support to bfd

Alan Modra amodra@gmail.com
Thu Dec 4 00:45:00 GMT 2014


On Wed, Dec 03, 2014 at 06:29:09PM -0500, Eric Botcazou wrote:
> +static bfd_vma
> +visium_set_even_parity (bfd_vma insn)
> +{
> +  bfd_vma p = 0;
> +  int i;
> +
> +  for (i = 0; i < 31; i++)
> +    {
> +      p += insn & 1;
> +      insn >>= 1;
> +    }
> +
> +  return p << 31;
> +}

Lose "set_" in the name, you're not setting anything here.
Also p ^= might save some future trouble, since bfd_vma can be 64-bit.

> +  sym_hashes_end =
> +    sym_hashes + symtab_hdr->sh_size / sizeof (Elf32_External_Sym);
> +  if (!elf_bad_symtab (abfd))
> +    sym_hashes_end -= symtab_hdr->sh_info;

You won't ever have elf_bad_symtab set and in any case, sym_hashes_end
looks to be unused.

> +   There is some attempt to make this function usable for many architectures,
> +   both USE_REL and USE_RELA ['twould be nice if such a critter existed],
> +   if only to serve as a learning tool.

Really?

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list