[PATCH] ARM Disassembler fix
Pedro Alves
pedro@codesourcery.com
Tue Jan 5 23:21:00 GMT 2010
On Tuesday 05 January 2010 22:17:46, Daniel Gutson wrote:
> Hi Pedro,
>
> Pedro Alves wrote:
> > On Monday 04 January 2010 20:43:29, Daniel Gutson wrote:
> > The patch breaks text disassembly on arm non-elf targets. Could
> > this be restrict to elf, please?
> I now restricted the value initialization of is_data depending on the
> obj flavour.
Thanks.
> ChangeLog is the same.
(I suggest always pasting the changelog with the patch, even
when it doesn't change between revisions; it makes it easier
for the person doing the actual reviewing [and maybe commit]
to have everything in one place.)
> Please let me know how does this look now.
The new test is now surely failing on non-elf targets. :-)
Could you skip it, please? Something like this should do it:
#skip: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd *-*-riscix*
Otherwise, I'm happy. Thanks.
--
Pedro Alves
More information about the Binutils
mailing list