[PATCH] ARM Disassembler fix

Daniel Gutson dgutson@codesourcery.com
Tue Jan 5 22:18:00 GMT 2010


Hi Pedro,

Pedro Alves wrote:
> On Monday 04 January 2010 20:43:29, Daniel Gutson wrote:
>> Hi Nick,
>>
>> Nick Clifton wrote:
>>> Hi Daniel,
>>>
>>>> The attached patch fixes a bug that causes the disassembler to dump 
>>>> code when it should dump data.
>>> This looks wrong to me.  Why should the disassembler assume that, in the 
>>> absence of mapping symbols to guide it, the .text section contains data 
>>> rather than instructions ?  Surely it is more likely to contain 
>>> instructions and it is merely that the mapping symbols are absent ?
> 
>> Please refer to the AAELF, i.e. IHI0044D pp 23, @4.6.5.1, e.g.
>> "A section must have a mapping symbol defined at the beginning of the 
>> section; however, if the section contains only data then the mapping 
>> symbol may be omitted."
> 
> The patch breaks text disassembly on arm non-elf targets.  Could
> this be restrict to elf, please?
> 

I now restricted the value initialization of is_data depending on the 
obj flavour.

ChangeLog is the same.

Please let me know how does this look now.

Thanks!
	Daniel.


-- 
Daniel Gutson
CodeSourcery
www.codesourcery.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: disasm_arm_v2.patch
Type: text/x-diff
Size: 2288 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100105/7cccd81b/attachment.bin>


More information about the Binutils mailing list