[PATCH] ARM Disassembler fix
Daniel Gutson
dgutson@codesourcery.com
Wed Jan 6 00:52:00 GMT 2010
Hi Pedro,
Pedro Alves wrote:
> On Tuesday 05 January 2010 22:17:46, Daniel Gutson wrote:
>> Hi Pedro,
>>
>> Pedro Alves wrote:
>>> On Monday 04 January 2010 20:43:29, Daniel Gutson wrote:
>>> The patch breaks text disassembly on arm non-elf targets. Could
>>> this be restrict to elf, please?
>> I now restricted the value initialization of is_data depending on the
>> obj flavour.
>
> Thanks.
>
>> ChangeLog is the same.
>
> (I suggest always pasting the changelog with the patch, even
> when it doesn't change between revisions; it makes it easier
> for the person doing the actual reviewing [and maybe commit]
> to have everything in one place.)
>
>> Please let me know how does this look now.
>
> The new test is now surely failing on non-elf targets. :-)
> Could you skip it, please? Something like this should do it:
>
> #skip: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd *-*-riscix*
DONE. (this is the only difference compared against the last patch).
ChangeLog:
2010-01-05 Daniel Gutson <dgutson@codesourcery.com>
opcodes/
* arm-dis.c (print_insn): Fixed search for next
symbol and data dumping condition, and the
initial mapping symbol state.
gas/testsuite/
* gas/arm/dis-data.d: New test case.
* gas/arm/dis-data.s: New file.
--
Daniel Gutson
CodeSourcery
www.codesourcery.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: disasm_arm_v3.patch
Type: text/x-diff
Size: 3181 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100106/b72d8397/attachment.bin>
More information about the Binutils
mailing list