Re: [PATCH] FreeBSD compatibility for <sys/select.h>

[Corinna Vinschen <vinschen at redhat dot com>]

On Dec 18 20:08, Nick Withers wrote:
> On Fri, 2015-12-18 at 10:02 +0100, Corinna Vinschen wrote:
> > On Dec 18 08:02, Sebastian Huber wrote:
> > > It seems to work with this change. I guess this is due to the
> > > include of
> > > <sys/select.h> in <sys/time.h>. Is this all right?
> > 
> > Including sys/select.h from sys/time.h is perfectly fine.  We already
> > did
> > that before, albeit only on Cygwin so far.  GLibc does it as well,
> > even
> > unconditionally (no guard along our #if __BSD_VISIBLE).  Only
> > sys/types.h
> > should not (must not per POSIX) expose the sys/select.h namespace.
> 
> POSIX 2004 / Issue 6 specifically allows it: 
> http://pubs.opengroup.org/onlinepubs/009604499/basedefs/sys/time.h.html
> 
> "Inclusion of the <sys/time.h> header may make visible all symbols from
> the <sys/select.h> header"

Yes, sys/time.h, but not sys/types.h.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpBNi5QqK6Ck.pgp
Description: PGP signature