This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] FreeBSD compatibility for <sys/select.h>
- From: Nick Withers <nick dot withers at anu dot edu dot au>
- To: <newlib at sourceware dot org>
- Date: Fri, 18 Dec 2015 20:08:34 +1100
- Subject: Re: [PATCH] FreeBSD compatibility for <sys/select.h>
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=nick dot withers at anu dot edu dot au;
- References: <1450083978-5786-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20151214144226 dot GD28594 at calimero dot vinschen dot de> <566FEF57 dot 9070301 at embedded-brains dot de> <20151215124133 dot GH3507 at calimero dot vinschen dot de> <20151217214620 dot GA32027 at calimero dot vinschen dot de> <5673AF69 dot 4050103 at embedded-brains dot de> <20151218090246 dot GA25797 at calimero dot vinschen dot de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
On Fri, 2015-12-18 at 10:02 +0100, Corinna Vinschen wrote:
> On Dec 18 08:02, Sebastian Huber wrote:
> > It seems to work with this change. I guess this is due to the
> > include of
> > <sys/select.h> in <sys/time.h>. Is this all right?
>
> Including sys/select.h from sys/time.h is perfectly fine. We already
> did
> that before, albeit only on Cygwin so far. GLibc does it as well,
> even
> unconditionally (no guard along our #if __BSD_VISIBLE). Only
> sys/types.h
> should not (must not per POSIX) expose the sys/select.h namespace.
POSIX 2004 / Issue 6 specifically allows it:
http://pubs.opengroup.org/onlinepubs/009604499/basedefs/sys/time.h.html
"Inclusion of the <sys/time.h> header may make visible all symbols from
the <sys/select.h> header"
--
Nick Withers
Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)