Re: [PATCH] Add typedef of stack_t for Cygwin

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 31 18:29, Joel Sherrill wrote:
> 
> 
> On 3/31/2015 6:20 PM, Jon TURNEY wrote:
> > On 31/03/2015 16:47, Joel Sherrill wrote:
> >> Why can't you move the definition that is there for RTEMS and use
> >> it for both Cygwin and RTEMS? We have exactly the same definition
> >> only a few lines above.
> >>
> >> There is no point in duplicating this and when Cygwin and RTEMS
> >> can use exactly the same code, I am personally much happier.
> > Ok.  Attached patch is revised as you suggest.
> >
> > I'm sorry I have no way to test this with RTEMS.
> >
> >
> It's OK. I think you would actually have to build tools, then RTEMS,
> then the new TCP/IP stack as an add-on package since it is an external
> package.
> 
> The patch looks OK to me.

Yes, it's fine.  We can also go the full way and remove any RTEMS
and Cygwin macro check for this as Sebastian proposes.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpdEAVfplhbh.pgp
Description: PGP signature