This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH,MIPS 1/3] Re-work setjmp/longjmp to match o32 FPXX and FP64 ABI

> On Nov 26 15:33, Steve Ellcey wrote:
> > On Wed, 2014-11-26 at 14:47 -0800, Matthew Fortune wrote:
> >
> > > This could then be used as GPR_FPOFFSET(11) instead of
> > > GPR_OFFSET(22) though it is perhaps just as confusing.
> > >
> > > Any suggestions and/or does it make more sense now?
> > >
> > > Thanks for the review,
> > > Matthew
> >
> > Thanks for the explanation, that helped.  I don't think the new macro
> > would help much but maybe some of the explanation from your email
> > could be put into the code comments.
> >
> > Steve Ellcey
> Thanks guys!  I agree with Steve.  The patch will be better
> understandable in future with the explanation as comment.

I've added a comment to cover what I said on this thread, it is phrased
as cleanly as I could think of. I am more than happy to work on it
further if anyone has any suggestions to improve it.


Attachment: 0001-Re-work-setjmp-longjmp-to-match-o32-FPXX-and-FP64-AB.patch
Description: 0001-Re-work-setjmp-longjmp-to-match-o32-FPXX-and-FP64-AB.patch

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]