This is the mail archive of the
mailing list for the newlib project.
Re: [PATCH] newlib patch for OpenRISC
- From: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- To: Hesham Moustafa <heshamelmatary at gmail dot com>, "newlib at sourceware dot org" <newlib at sourceware dot org>
- Date: Thu, 17 Jul 2014 10:43:40 -0500
- Subject: Re: [PATCH] newlib patch for OpenRISC
- Authentication-results: sourceware.org; auth=none
- References: <1405116429-998-1-git-send-email-heshamelmatary at gmail dot com> <20140714134422 dot GB2160 at calimero dot vinschen dot de> <CA+wsVCAP=+K+VDYvCkO3AQ_CUSee=-i_O+JM_Oab2s-DRbi7xw at mail dot gmail dot com> <53C5BBF3 dot 2090600 at oarcorp dot com> <20140716074135 dot GV10401 at calimero dot vinschen dot de> <CA+wsVCChuucBxjU=JOH6U_MmntRe3bVJZ7vr0EFZODkRAzyqNQ at mail dot gmail dot com>
This looks ok to me.
Corinna. The ChangeLog doesn't mention the new configure
script. Should it?
And could you commit it please? I am more comfortable that
you will generate the correct configure file than I am. :(
On 7/16/2014 10:20 PM, Hesham Moustafa wrote:
> I have added an entry to ChangeLog at newlib directory. Please review
> the attached patch.
> On Wed, Jul 16, 2014 at 9:41 AM, Corinna Vinschen <firstname.lastname@example.org> wrote:
>> On Jul 15 18:40, Joel Sherrill wrote:
>>> On 7/15/2014 4:14 PM, Hesham Moustafa wrote:
>>>> On Mon, Jul 14, 2014 at 3:44 PM, Corinna Vinschen <email@example.com> wrote:
>>>>> On Jul 12 00:07, Hesham ALMatary wrote:
>>>>>> From: hesham <hesham@hesham-laptop.(none)>
>>>>>> The following patch is part of my GSoC project--Porting RTEMS to OpenRISC. It
>>>>>> adds minimal OpenRISC port to newlib without any libgloss stuff.
>>>>> A ChangeLog entry would be nice.
>>> Once that's posted, is this OK to merge?
>>> The OpenRISC folks have libgloss code they can submit. This lets
>>> the RTEMS port move forward.
>>>>> The patch looks basically ok, but
>>>>> what happened with or16 and or32 target names? Can you provide some
>>>>> background why it's ok to nuke them?
>>>> All or32 targets has been renamed to or1k now (I believe because of
>>>> the new 64 bit
>>>> addition). Also, the new binutils patch here  did this renaming. GCC, GDB
>>>> and RTEMS also follow or1k target name. or32, or16 are no longer used/defined by
>>>> any of them.
>>>>  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=73589c9dbddc7906fa6a150f2a2a0ff6b746e8ba
>>> Yeah.. this was easy to sleep through but it happened. :)
>> Thanks. Please go ahead and check it in, Joel.
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available (256) 722-9985