This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][AArch64][libgloss] Tidy up WXN bit clearing

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Tue, 28 Jan 2014 12:16:34 +0100
Subject: Re: [PATCH][AArch64][libgloss] Tidy up WXN bit clearing
Authentication-results: sourceware.org; auth=none
References: <52E77305 dot 7000808 at arm dot com> <52E7738D dot 7030406 at arm dot com>
Reply-to: newlib at sourceware dot org

On Jan 28 09:08, Marcus Shawcroft wrote:
> On 28/01/14 09:06, Kyrill Tkachov wrote:
> >Hi all,
> >
> >The patch I sent out recently to clear the WXN bit could be improved a bit.
> >We can use the assembler bic-immediate pseudo-instruction instead of a
> >mov-immediate and register-bic.
> >This patch shortens that sequence a bit.
> >
> >Sorry for the noise.
> >
> >Ok?
> >
> >Tested aarch64-none-elf on a model.
> >
> >P.S. Can someone please install this if ok'd?
> >
> >[libgloss/]
> >2014-01-28  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> >
> >      * aarch64/cpu-init/rdimon-aem-el3.S (flat_map): Use bic-immediate
> >      form to clear WXN bit.
> >
> 
> Looks good to me.
> /Marcus

Patch applied.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgphsQtytVVca.pgp
Description: PGP signature

References:
- [PATCH][AArch64][libgloss] Tidy up WXN bit clearing
  - From: Kyrill Tkachov
- Re: [PATCH][AArch64][libgloss] Tidy up WXN bit clearing
  - From: Marcus Shawcroft

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]