This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [RFC]setlocale() race condition
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Sharyathi Nagesh" <sharyath at in dot ibm dot com>
- Cc: libc-help at sourceware dot org, "Mark Brown" <bmark at us dot ibm dot com>, sripathik at in dot ibm dot com, suzuki at in dot ibm dot com, tim_preece at uk dot ibm dot com
- Date: Thu, 26 Jun 2008 10:06:25 -0400
- Subject: Re: [RFC]setlocale() race condition
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=mQhDwpez/cLSHwVuUsG8mIBz/WhFE9lRneNRYw+nCpg=; b=JwgfpHbip5a6AY8aZUmjIgmFj/8SdWZx3yiwpurFig2UK5udCYGh1fJYgPsdSoTCYq KOKKB7SOtF7r5GTLDqcZ6B9I5GcKRUAlCs11nwpyLK60veLZGIphVgW1LPbNwwd32JgS J2Cp152ahmxID31MnwvLu3/rxxRkdIHSf/l5E=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=sM2bhvrHDnV8j3q/JEzXtN6qlicZKqhLyOfU9/nW1GoR87ISr6P1cDomYSoO+vydoJ CTm5PX1H5SU0I7OyeubskNAu9npg52Cbbiv9Llgyf7sdh9Lq+VrJTOPRGj1XpwuMu5nN twAd99nPz07UslOPl31mtmOK4vHHKmuO7xx40=
- References: <48509BC2.8040102@in.ibm.com> <OF63289371.657FC9A8-ON86257466.00590DCB-86257466.005A1854@us.ibm.com> <48520904.8020406@in.ibm.com> <119aab440806130651g4b598fa7wdf2c589276163f9a@mail.gmail.com> <119aab440806130654l65085bfdlc7ce66e6c9f743d7@mail.gmail.com> <485755DE.6060608@in.ibm.com> <119aab440806170448r4be70351pa70aa9559fe19322@mail.gmail.com> <4858D94F.3070800@in.ibm.com> <119aab440806180922x6a59d885qadb87a40ced1bc0a@mail.gmail.com> <48607C6D.7050208@in.ibm.com>
On Tue, Jun 24, 2008 at 12:47 AM, Sharyathi Nagesh <sharyath@in.ibm.com> wrote:
> Carlos
> Excuse me for the late response
> Here is the mail with update as you suggested
Excellent work! You've come a long way from your original posting.
> ========================================================================
> GNU Changelog
>
> 2008-06-12 Sharyathi Nagesh <sharyathi@in.ibm.com>
> * locale/setlocale.c (setlocale): Fix Race condition while
> calling strcmp().
The format of the ChangeLog is not correct.
Please see the GNU Coding Standards (http://www.gnu.org/prep/standards/).
The canonical format is:
[yy-mm-dd][2 spaces][name][2 spaces]<[email]>
[blank line]
[tab]*[1 space][filename][1 space]([function]:[1 space][description]
The description is not correct either. The text should succinctly
describe what you did e.g. "Call FOO before accessing BAR."
Cheers,
Carlos O'Donell