This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [review v2] wcsrtombs: Do not call wcsnlen on input with wrong length [BZ #23711]
- From: Florian Weimer <fweimer at redhat dot com>
- To: libc-alpha at sourceware dot org
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, Carlos O'Donell <carlos at redhat dot com>
- Date: Wed, 30 Oct 2019 11:36:54 +0100
- Subject: Re: [review v2] wcsrtombs: Do not call wcsnlen on input with wrong length [BZ #23711]
- References: <gerrit.1572431418000.I5b28fb36c8d224cf69910fb436ff76bff8f129f6@gnutoolchain-gerrit.osci.io> <20191030103237.7405620AF6@gnutoolchain-gerrit.osci.io>
* Florian Weimer:
> Florian Weimer has posted comments on this change.
>
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/445
> ......................................................................
>
>
> Patch Set 2:
>
> This change is ready for review.
That is not right because the patch is missing from the email
notification. 8-(
I submitted the patch as a WIP, to see what it would look like in
Gerrit. I think this staging is quite useful as a feature.
The manual says this:
| Alternatively, click Ready from the Change screen.
<https://gnutoolchain-gerrit.osci.io/r/Documentation/intro-user.html#wip>
But I do not see this button. I clicked “Start Review” instead,
resulting in the notification above and a spurious v2 being created.
(Or maybe that happened because I edited the commit message in Gerrit?)
Thanks,
Florian