This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix build warnings in nptl/tst-eintr1.c


On 6/25/19 3:33 PM, Stefan Liebler wrote:
On 6/25/19 3:19 PM, Florian Weimer wrote:
* Stefan Liebler:

diff --git a/nptl/tst-eintr1.c b/nptl/tst-eintr1.c
index b60b796d61..256f5e94f8 100644
--- a/nptl/tst-eintr1.c
+++ b/nptl/tst-eintr1.c
@@ -43,6 +43,7 @@ tf1 (void *arg)
        pthread_t th = xpthread_create (NULL, tf2, NULL);
        xpthread_join (th);
      }
+  return NULL;
  }
@@ -54,7 +55,7 @@ do_test (void)
    int i;
    for (i = 0; i < 10; ++i)
      {
-      pthread_t th = xpthread_create (NULL, tf1, NULL);
+      xpthread_create (NULL, tf1, NULL);
      }

Looks good.  But you could remove the braces from the for loop, too.
Okay. That's no problem. If no one opposes, I'll commit the patch tomorrow without the braces.

Thanks,
Florian


Committed.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]