This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Fix build warnings in nptl/tst-eintr1.c
- From: Stefan Liebler <stli at linux dot ibm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 25 Jun 2019 15:15:45 +0200
- Subject: [PATCH] Fix build warnings in nptl/tst-eintr1.c
Hi,
this patch fixes the gcc warnings seen with gcc 9.1 -O3 on s390x:
tst-eintr1.c: In function ‘tf1’:
tst-eintr1.c:46:1: error: no return statement in function returning
non-void [-Werror=return-type]
46 | }
| ^
tst-eintr1.c: In function ‘do_test’:
tst-eintr1.c:57:17: error: unused variable ‘th’ [-Werror=unused-variable]
57 | pthread_t th = xpthread_create (NULL, tf1, NULL);
| ^~
Bye
Stefan
ChangeLog:
* nptl/tst-eintr1.c (tf1): Add return statement.
(do_test): Remove unused th variable.
commit 2d77bc90e2d16f88eb242c3daf2778b009a9234e
Author: Stefan Liebler <stli@linux.ibm.com>
Date: Mon Jun 24 12:11:48 2019 +0200
Fix build warnings in nptl/tst-eintr1.c
This patch fixes the gcc warnings seen with gcc 9.1 -O3 on s390x:
tst-eintr1.c: In function â??tf1â??:
tst-eintr1.c:46:1: error: no return statement in function returning non-void [-Werror=return-type]
46 | }
| ^
tst-eintr1.c: In function â??do_testâ??:
tst-eintr1.c:57:17: error: unused variable â??thâ?? [-Werror=unused-variable]
57 | pthread_t th = xpthread_create (NULL, tf1, NULL);
| ^~
ChangeLog:
* nptl/tst-eintr1.c (tf1): Add return statement.
(do_test): Remove unused th variable.
diff --git a/nptl/tst-eintr1.c b/nptl/tst-eintr1.c
index b60b796d61..256f5e94f8 100644
--- a/nptl/tst-eintr1.c
+++ b/nptl/tst-eintr1.c
@@ -43,6 +43,7 @@ tf1 (void *arg)
pthread_t th = xpthread_create (NULL, tf2, NULL);
xpthread_join (th);
}
+ return NULL;
}
@@ -54,7 +55,7 @@ do_test (void)
int i;
for (i = 0; i < 10; ++i)
{
- pthread_t th = xpthread_create (NULL, tf1, NULL);
+ xpthread_create (NULL, tf1, NULL);
}
delayed_exit (3);