This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix build warnings in nptl/tst-eintr1.c
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stefan Liebler <stli at linux dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 25 Jun 2019 15:19:31 +0200
- Subject: Re: [PATCH] Fix build warnings in nptl/tst-eintr1.c
- References: <3f551a0b-1c2b-d215-878a-4259789fc58e@linux.ibm.com>
* Stefan Liebler:
> diff --git a/nptl/tst-eintr1.c b/nptl/tst-eintr1.c
> index b60b796d61..256f5e94f8 100644
> --- a/nptl/tst-eintr1.c
> +++ b/nptl/tst-eintr1.c
> @@ -43,6 +43,7 @@ tf1 (void *arg)
> pthread_t th = xpthread_create (NULL, tf2, NULL);
> xpthread_join (th);
> }
> + return NULL;
> }
>
>
> @@ -54,7 +55,7 @@ do_test (void)
> int i;
> for (i = 0; i < 10; ++i)
> {
> - pthread_t th = xpthread_create (NULL, tf1, NULL);
> + xpthread_create (NULL, tf1, NULL);
> }
Looks good. But you could remove the braces from the for loop, too.
Thanks,
Florian