This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v1 10/16] RISC-V: The ABI implementation for the 32-bit
- From: Palmer Dabbelt <palmer at sifive dot com>
- To: Arnd Bergmann <arnd at arndb dot de>
- Cc: Alistair Francis <Alistair dot Francis at wdc dot com>, libc-alpha at sourceware dot org, alistair23 at gmail dot com
- Date: Sun, 23 Jun 2019 19:49:35 -0700 (PDT)
- Subject: Re: [RFC v1 10/16] RISC-V: The ABI implementation for the 32-bit
On Sun, 23 Jun 2019 12:41:20 PDT (-0700), Arnd Bergmann wrote:
On Sat, Jun 22, 2019 at 6:47 AM Alistair Francis
<alistair.francis@wdc.com> wrote:
sysdeps/unix/sysv/linux/riscv/rv32/lockf64.c | 70 +++++++++++++++++++
Why is this file architecture specific? It seems everything else just uses
#include <sysdeps/unix/sysv/linux/i386/lockf64.c>
Is your code different from that version?
As part of the code review it was indicated that we shouldn't #include C files
but should instead duplicate them. At the time it was exactly the same, we
should scrutinize any differences as that was months ago.