This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v1 10/16] RISC-V: The ABI implementation for the 32-bit
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Palmer Dabbelt <palmer at sifive dot com>
- Cc: Alistair Francis <Alistair dot Francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Alistair Francis <alistair23 at gmail dot com>
- Date: Mon, 24 Jun 2019 11:51:25 +0200
- Subject: Re: [RFC v1 10/16] RISC-V: The ABI implementation for the 32-bit
- References: <CAK8P3a0ofPn8EPSgOg36BXOOe3Jjdbw0euvak=+w9KJ-8h9_Yw@mail.gmail.com> <mhng-8aab6919-d6ad-44e0-9221-fda9b350785c@palmer-si-x1e>
On Mon, Jun 24, 2019 at 4:49 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Sun, 23 Jun 2019 12:41:20 PDT (-0700), Arnd Bergmann wrote:
> > On Sat, Jun 22, 2019 at 6:47 AM Alistair Francis
> > <alistair.francis@wdc.com> wrote:
> >
> >> sysdeps/unix/sysv/linux/riscv/rv32/lockf64.c | 70 +++++++++++++++++++
> >
> > Why is this file architecture specific? It seems everything else just uses
> > #include <sysdeps/unix/sysv/linux/i386/lockf64.c>
> > Is your code different from that version?
>
> As part of the code review it was indicated that we shouldn't #include C files
> but should instead duplicate them. At the time it was exactly the same, we
> should scrutinize any differences as that was months ago.
I would expect that you would want it to be consistent across architectures
as well: so either replace all the other #include versions with direct copies,
or move the file into a more generic location that avoids the #include if you
can't add another one any more.
Arnd