This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix bits/socket.h SIOCGSTAMP* namespace issues
- From: Florian Weimer <fweimer at redhat dot com>
- To: Vincent Chen <vincentc at andestech dot com>
- Cc: <libc-alpha at sourceware dot org>, <deanbo422 at gmail dot com>
- Date: Thu, 13 Jun 2019 10:41:13 +0200
- Subject: Re: [PATCH] Fix bits/socket.h SIOCGSTAMP* namespace issues
- References: <1560395203-6944-1-git-send-email-vincentc@andestech.com>
* Vincent Chen:
> Macro SIOCGSTAMP_OLD and SIOCGSTAMPNS_OLD are added to asm/socket.h in
> Linux 5.1 for 64-bit timestamps implementation.
>
> sysdeps/unix/sysv/linux/bits/socket.h includes asm/socket.h. That
> includes asm/sockios.h resulting in namespace violations from
> SIOCGSTAMP_OLD and SIOCGSTAMPNS_OLD macros. Add these two macros to
> workaound list in sysdeps/unix/sysv/linux/bits/socket.h like other
> macros in asm/sockios.h.
I wonder if it is time to copy the definitions we need for !_GNU_SOURCE
into the glibc source tree. It would also address the recent namespace
cleanliness issue. Only some architectures (alpha, mips, hppa, powerpc,
sparc) have custom definitions in the UAPI headers, it seems. For
_GNU_SOURCE, we would still include <asm/socket.h>.
Or am I totally off about this and it doesn't make sense?
Would you want to work on this? It requires a reasonably fast machine
for running build-many-glibcs.py.
Thanks,
Florian