Re: [PATCH] Fix bits/socket.h SIOCGSTAMP* namespace issues

[Vincent Chen <vincentc at andestech dot com>]

On Thu, Jun 13, 2019 at 04:41:13PM +0800, Florian Weimer wrote:
> * Vincent Chen:
> 
> > Macro SIOCGSTAMP_OLD and SIOCGSTAMPNS_OLD are added to asm/socket.h in
> > Linux 5.1 for 64-bit timestamps implementation.
> >
> > sysdeps/unix/sysv/linux/bits/socket.h includes asm/socket.h. That
> > includes asm/sockios.h resulting in namespace violations from
> > SIOCGSTAMP_OLD and SIOCGSTAMPNS_OLD macros. Add these two macros to
> > workaound list in sysdeps/unix/sysv/linux/bits/socket.h like other
> > macros in asm/sockios.h.
> 
> I wonder if it is time to copy the definitions we need for !_GNU_SOURCE
> into the glibc source tree.  It would also address the recent namespace
> cleanliness issue.  Only some architectures (alpha, mips, hppa, powerpc,
> sparc) have custom definitions in the UAPI headers, it seems.  For
> _GNU_SOURCE, we would still include <asm/socket.h>.
> 
> Or am I totally off about this and it doesn't make sense?

I think your concerns are reasonable.

> Would you want to work on this?  It requires a reasonably fast machine
> for running build-many-glibcs.py.
>
Currently, I do not have enough resource to do this.
Hence, If anyone wants to work on this, I will be very grateful.


Thanks,
Vincent Chen