This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 14/28] math: Use wordsize-64 version for isinf
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Thu, 13 Jun 2019 08:57:33 +0000
- Subject: Re: [PATCH 14/28] math: Use wordsize-64 version for isinf
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-15-adhemerval.zanella@linaro.org>
On 29/03/2019 13:35, Adhemerval Zanella wrote:
> - math.h will use compiler builtin for gcc 4.4+ when built without
> -fsignaling-nans and the builtin is expanded inline for all
> supported architectures. As an example, there is no intra isnan
> call on libm for the architecture I checked (x86, arm, aarch64,
> and powerpc).
>
> - The resulting binary difference on 32 bits architecture is minimum
> for the non hotspot symbol.
>
> - It helps wordsize-64 architectures that use ldbl-opt.
>
> - It add some code simplification with reduction of duplicated
> implementations.
>
> Checked on powerpc-linux-gnu (built without --with-cpu, with
> --with-cpu=power4 and with --with-cpu=power5+ and --disable-multi-arch),
> powerpc64-linux-gnu (built without --with-cp and with --with-cpu=power5+
> and --disable-multi-arch).
>
> * sysdeps/ieee754/dbl-64/wordsize-64/s_isinf.c: Move to ...
> * sysdeps/ieee754/dbl-64/s_isinf.c: ... here and format code.
on aarch64 buildbot i see
make[2]: *** No rule to make target '../sysdeps/ieee754/dbl-64/wordsize-64/s_isinf.c', needed by '/B/math/s_isinf.o'.
make[2]: *** No rule to make target '../sysdeps/ieee754/dbl-64/wordsize-64/s_isnan.c', needed by '/B/math/s_isnan.o'.
make[2]: *** No rule to make target '../sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c', needed by '/B/math/s_finite.o'.
make[2]: Target 'subdir_lib' not remade because of errors.
make[1]: *** [Makefile:259: math/subdir_lib] Error 2