This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [powerpc] fegetmode: utilize faster method to get rounding mode

From: Paul Clarke <pc at us dot ibm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org, tuliom at ascii dot art dot br
Date: Mon, 10 Jun 2019 13:51:59 -0500
Subject: Re: [PATCH] [powerpc] fegetmode: utilize faster method to get rounding mode
References: <1559870599-2079-1-git-send-email-pc@us.ibm.com> <alpine.DEB.2.21.1906101532150.29610@digraph.polyomino.org.uk>

On 6/10/19 10:36 AM, Joseph Myers wrote:
> On Thu, 6 Jun 2019, Paul A. Clarke wrote:
>> From: "Paul A. Clarke" <pc@us.ibm.com>
>> Add support to use 'mffsl' instruction if compiled for POWER9 (or later).
> 
> The patch subject says "rounding mode".  fegetmode should save all control 
> modes, not just the rounding mode.  (The C2x wording is "all the dynamic 
> floating-point control modes".)
> 
> My understanding is that the change is in fact correct - mffsl does save 
> all control modes (e.g. exception enable and non-IEEE bit), not just the 
> rounding mode (and includes both binary and decimal rounding modes) - and 
> so this is just an issue with the patch description, not the code changes.

Good catch, and your understanding is correct.  I will update the description in v2,
which will also incorporate Adhemerval's suggestion.  Coming soon.

PC

References:
- [PATCH] [powerpc] fegetmode: utilize faster method to get rounding mode
  - From: Paul A. Clarke
- Re: [PATCH] [powerpc] fegetmode: utilize faster method to get rounding mode
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]